no-same-line-conditional
November 22, 2023 ยท View on GitHub
:wrench: fixable
Code is clearest when each statement has its own line. Nonetheless, it is a common pattern to combine on the same line an if and its resulting then statement. However, when an if is placed on the same line as the closing } from a preceding then, else or else if part, it is either an error - else is missing - or the invitation to a future error as maintainers fail to understand that the two statements are unconnected.
Noncompliant Code Example
if (condition1) {
// ...
} if (condition2) { // Noncompliant
//...
}
Compliant Solution
if (condition1) {
// ...
} else if (condition2) {
//...
}
Or
if (condition1) {
// ...
}
if (condition2) {
//...
}