Security
March 21, 2022 ยท View on GitHub
Please read the guidelines in https://github.com/decentraland/standards
Security
Sign all your commits with GPG
- https://github.com/blog/2144-gpg-signature-verification
- https://help.github.com/articles/generating-a-new-gpg-key/
- https://help.github.com/articles/signing-commits-using-gpg/
Commit messages
We do semantic commits
feat: add hat wobble
^--^ ^------------^
| |
| +-> Summary in present tense.
|
+-------> Type: chore, docs, feat, fix, refactor, style, or test.
Examples:
chore: add Oyster build script
docs: explain hat wobble
feat: add beta sequence, implements #332
fix: remove broken confirmation message, closes #123
refactor: share logic between 4d3d3d3 and flarhgunnstow
style: convert tabs to spaces
test: ensure Tayne retains clothing
Allowed <type> values:
featnew featurefixbug fixdocschanges to the documentationstyleformatting, linting, etc; no production code changerefactorrefactoring production code, eg. renaming a variabletestadding missing tests, refactoring tests; no production code changechoreupdating build tasks etc; no production code change
Merge commits
Avoid Merge branch 'a' into 'master' commit messages. Rebase when possible
Code style
Every commit should be linted using the command npm run lint:fix
For TypeScript (and react specific) guidelines refer to https://github.com/decentraland/standards/blob/master/standards/react-redux.md